bootstrap: improve 'build --help' by explaining what exactly the last example does #42491
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
I looked at your diff before reading your comment, and this confused me independently. Pretty sure it should be 'compiler'.
The compiler built during Targeting stage 1 |
aidanhs
added
the
S-waiting-on-review
|
Looks good to me! The wording in the PR description also looks great to me, want to insert that as well? |
I guess my question is, where is that sysroot? Nothing seems to actually assemble that compiler and its compatible libstd in a single folder hierarchy when I just say @alexcrichton will do. |
|
I inserted the wording from the PR description, and confirmed that it is actually true -- i.e., that the given folder (starting with a clean checkout) actually contains a usable compiler. |
|
@bors: r+ Thanks!
Technically |
|
📌 Commit 7359c79 has been approved by |
…hton
bootstrap: improve 'build --help' by explaining what exactly the last example does
I recently found myself confused about what exactly gets built how often when I run which command; I think this would have helped me.
One thing I did not touch, but I feel could also be improved, is the wording just above: "For a quick build with a usable compile, you can pass". I am not a native speaker, but this sounds odd to me. Do you mean "For a quick build of a usable compiler" (but then it should say where the usable compiler is produced)? Or do you mean "For a quick build testing if the compiler is usable"? I can reword this, but I'd like to make sure I understand the intent of the message.
What about
```
For a quick build of a usable compiler, you can pass:
./x.py build --stage 1 src/libtest
This will first build everything once (like --stage 0 without further
arguments would), and then use the compiler built in stage 0 to build
src/libtest and its dependencies.
Once this is done, build/$ARCH/stage1 contains a usable compiler.
```
However, I am not sure this is actually true. In particular, why even bother building the libstd in stage 1? AFAIK that ends up in `build/*/stage1-std`, not in `build/*/stage1` (which is filled from `build/*/stage0-*`).
bootstrap: improve 'build --help' by explaining what exactly the last example does
I recently found myself confused about what exactly gets built how often when I run which command; I think this would have helped me.
One thing I did not touch, but I feel could also be improved, is the wording just above: "For a quick build with a usable compile, you can pass". I am not a native speaker, but this sounds odd to me. Do you mean "For a quick build of a usable compiler" (but then it should say where the usable compiler is produced)? Or do you mean "For a quick build testing if the compiler is usable"? I can reword this, but I'd like to make sure I understand the intent of the message.
What about
```
For a quick build of a usable compiler, you can pass:
./x.py build --stage 1 src/libtest
This will first build everything once (like --stage 0 without further
arguments would), and then use the compiler built in stage 0 to build
src/libtest and its dependencies.
Once this is done, build/$ARCH/stage1 contains a usable compiler.
```
However, I am not sure this is actually true. In particular, why even bother building the libstd in stage 1? AFAIK that ends up in `build/*/stage1-std`, not in `build/*/stage1` (which is filled from `build/*/stage0-*`).
|
☀️ Test successful - status-appveyor, status-travis |
I recently found myself confused about what exactly gets built how often when I run which command; I think this would have helped me.
One thing I did not touch, but I feel could also be improved, is the wording just above: "For a quick build with a usable compile, you can pass". I am not a native speaker, but this sounds odd to me. Do you mean "For a quick build of a usable compiler" (but then it should say where the usable compiler is produced)? Or do you mean "For a quick build testing if the compiler is usable"? I can reword this, but I'd like to make sure I understand the intent of the message.
What about
However, I am not sure this is actually true. In particular, why even bother building the libstd in stage 1? AFAIK that ends up in
build/*/stage1-std, not inbuild/*/stage1(which is filled frombuild/*/stage0-*).